[webkit-reviews] review granted: [Bug 127532] Removing the need for Debugger* and m_shouldPause op_debug check : [Attachment 222084] patch 2: fixed initialization bug.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 127532: Removing the need for Debugger* and m_shouldPause op_debug check
https://bugs.webkit.org/show_bug.cgi?id=127532

Attachment 222084: patch 2: fixed initialization bug.
https://bugs.webkit.org/attachment.cgi?id=222084&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222084&action=review


r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   with a procedure to toffle a SteppingMode flag on all CodeBlocks
under

"toggle"

> Source/JavaScriptCore/bytecode/CodeBlock.h:1032
> +	       signed m_numBreakpoints : 31;

Why is this signed?

> Source/JavaScriptCore/debugger/Debugger.cpp:193
> +    clearDebuggerRequestsInGlobal(globalObject);

No need for "InGlobal" in the name. The global object parameter is a part of
the function signature.

> Source/JavaScriptCore/debugger/Debugger.cpp:223
> +void Debugger::toggleSteppingMode(SteppingMode mode)

This should be "setSteppingMode". Same for other uses of "toggle" in this
patch.