[webkit-reviews] review granted: [Bug 107820] [EFL][WK2] Use C API inside ewk_settings : [Attachment 222078] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 107820: [EFL][WK2] Use C API inside ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=107820

Attachment 222078: Patch
https://bugs.webkit.org/attachment.cgi?id=222078&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222078&action=review


> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:278
> +    ,
m_settings(std::make_unique<EwkSettings>(WKPageGroupGetPreferences(WKPageGetPag
eGroup(wkPage()))))

LGTM, however, Benjamin might have a concern about this.