[webkit-reviews] review granted: [Bug 127502] IDB: Implement SQLite backing store 'get' support : [Attachment 222048] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 19:45:27 PST 2014


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 127502: IDB: Implement SQLite backing store 'get' support
https://bugs.webkit.org/show_bug.cgi?id=127502

Attachment 222048: Patch v1
https://bugs.webkit.org/attachment.cgi?id=222048&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222048&action=review


> Source/WebCore/platform/sql/SQLiteDatabase.cpp:511
> +    std::function<int(int, const void*, int, const void*)>* f =
static_cast<std::function<int(int, const void*, int, const void*)>*>(arg);

these seem like one of the canonical "pure win" places to use auto.


More information about the webkit-reviews mailing list