[webkit-reviews] review granted: [Bug 127530] Web Inspector: Refactor bar combining logic into a TimelineRecordBar helper : [Attachment 222063] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 19:12:10 PST 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 127530: Web Inspector: Refactor bar combining logic into a
TimelineRecordBar helper
https://bugs.webkit.org/show_bug.cgi?id=127530

Attachment 222063: Patch
https://bugs.webkit.org/attachment.cgi?id=222063&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222063&action=review


Clean! r=me

> Source/WebInspectorUI/ChangeLog:49
> +	   Lazy create DOM elements. Support rendering one or both segments.
Doing this lets

Typo: Lazy => Lazily

> Source/WebInspectorUI/ChangeLog:50
> +	   combined inactive segments to sit behind multiple active segments.

Typo: "combined inactive segments to sit" => "combined inactive segments sit"

> Source/WebInspectorUI/UserInterface/NetworkTimelineOverviewGraph.css:27
> +    padding-top: 3px

Nit: Missing semicolon.

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:238
> +	   var barEndTime = this._records.reduce(function(previousValue,
currentValue) { return Math.max(previousValue, currentValue.endTime); }, 0);

The list is no longer sorted?

Nit: Up above, out of context, there is a "return;" that should be "return
false;"


More information about the webkit-reviews mailing list