[webkit-reviews] review granted: [Bug 127275] Move HistoryItem to std::unique_ptr : [Attachment 222021] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 16:41:28 PST 2014


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 127275: Move HistoryItem to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127275

Attachment 222021: Patch
https://bugs.webkit.org/attachment.cgi?id=222021&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222021&action=review


> Source/WebKit/mac/History/WebHistoryItem.mm:391
> +	   std::unique_ptr<Vector<String>> redirectURLsVector =
std::make_unique<Vector<String>>(size);

Seems like a good place to use auto:

    auto redirectURLsVector = std::make_unique<Vector<String>>(size);


More information about the webkit-reviews mailing list