[webkit-reviews] review granted: [Bug 127520] Explicitly link XPC services with AppKit : [Attachment 222034] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127520: Explicitly link XPC services with AppKit
https://bugs.webkit.org/show_bug.cgi?id=127520

Attachment 222034: Patch
https://bugs.webkit.org/attachment.cgi?id=222034&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222034&action=review


> Source/WebKit2/ChangeLog:3
> +	   Explicitly link XPC services with AppKit

You're only doing this to a subset of the XPC services. It might be worth
mentioning why that subset is special.

> Source/WebKit2/Configurations/PluginService.64.xcconfig:38
> +FRAMEWORK_LDFLAGS = -framework Foundation 
$(FRAMEWORK_LDFLAGS_$(DEBUG_OR_RELEASE));

May as well revert this bit.