[webkit-reviews] review granted: [Bug 127358] Improve the bindings of NodeList's name accessor : [Attachment 221768] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 15:06:07 PST 2014


Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 127358: Improve the bindings of NodeList's name accessor
https://bugs.webkit.org/show_bug.cgi?id=127358

Attachment 221768: Patch
https://bugs.webkit.org/attachment.cgi?id=221768&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221768&action=review


r=me

> Source/WebCore/bindings/js/JSNodeListCustom.cpp:57
> +	   slot.setValue(this, ReadOnly | DontDelete | DontEnum, toJS(exec,
globalObject(), item));

I think this works.

Please add a test to double-check that you haven't changed behavior of this
property according to for-in enumeration and/or
Object.getOwnPropertyDescriptor. Those are our best ways to test where the
attributes set on the property are correct.


More information about the webkit-reviews mailing list