[webkit-reviews] review denied: [Bug 127470] Remove unused RuntimeEnabledFeatures : [Attachment 221960] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 127470: Remove unused RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=127470

Attachment 221960: Patch
https://bugs.webkit.org/attachment.cgi?id=221960&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
EWS is red, saying that these are used in generated code:

/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow
.cpp:4922:51: error: no member named 'webSocketEnabled' in
'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().webSocketEnabled())
	 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow
.cpp:8984:51: error: no member named 'sharedWorkerEnabled' in
'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().sharedWorkerEnabled())
	 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

IndexedDB is disabled IIRC, otherwise it would almost certainly fail too.