[webkit-reviews] review granted: [Bug 122847] Enable DFG for the Debugger and Profiler : [Attachment 222022] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 122847: Enable DFG for the Debugger and Profiler
https://bugs.webkit.org/show_bug.cgi?id=122847

Attachment 222022: the patch.
https://bugs.webkit.org/attachment.cgi?id=222022&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

The next two improvements you should make are:

(1) Remove the speculation checks for debugger and "shouldPause", and change
the debugger to add a breakpoint to every code block when it starts stepping,
and remove them all when it stops stepping.

(2) Change the *_profile_* opcodes to speculation check a boolean that
indicates whether a profiler is currently recording. (i.e., an attached
profiler that is not currently recording should take the fast path.)