[webkit-reviews] review granted: [Bug 127483] Merge Chromium TextTrack cleanups : [Attachment 221986] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 09:49:23 PST 2014


Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 127483: Merge Chromium TextTrack cleanups
https://bugs.webkit.org/show_bug.cgi?id=127483

Attachment 221986: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=221986&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221986&action=review


> Source/WebCore/html/HTMLTrackElement.h:91
> +    bool canLoadUrl(const URL&);

Should be named canLoadURL.

> Source/WebCore/loader/TextTrackLoader.cpp:79
> +	   m_resource = 0;

nullptr


More information about the webkit-reviews mailing list