[webkit-reviews] review requested: [Bug 127421] [curl] Improve realm string parsing in WWW-Authenticate headers : [Attachment 221966] Proposed patch II.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 02:38:36 PST 2014


Szabolcs David <davidsz at inf.u-szeged.hu> has asked  for review:
Bug 127421: [curl] Improve realm string parsing in WWW-Authenticate headers
https://bugs.webkit.org/show_bug.cgi?id=127421

Attachment 221966: Proposed patch II.
https://bugs.webkit.org/attachment.cgi?id=221966&action=review

------- Additional Comments from Szabolcs David <davidsz at inf.u-szeged.hu>
Thanks for your comments!

> What happens if we get the input ""? Are we supposed to create a protection
space for the "" realm? Or should we be bailing out early?

I think we should accept the empty string as realm, because the most popular
browsers accept it too.


More information about the webkit-reviews mailing list