[webkit-reviews] review granted: [Bug 127439] AX: Disable accessibility after every test run : [Attachment 221915] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 127439: AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Attachment 221915: patch
https://bugs.webkit.org/attachment.cgi?id=221915&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221915&action=review


r=me as is, however please consider using Internals instead.

> Source/WebKit/mac/WebView/WebFrame.mm:2171
> +- (void)accessibilitySetEnabled:(BOOL)enabled

AXObjectCache is a WebCore class, so it's a better to expose the accessors via
Internals, not via private APIs - unless it has uses besides testing.

That way, you only need to do it once, not for each port, and there is no risk
of someone starting to use the API and forcing us to support it in the future.