[webkit-reviews] review granted: [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer : [Attachment 221932] [PATCH] Proposed Fix - Passing Tests

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 127409: Web Inspector: Remove recompileAllJSFunctions timer in
ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=127409

Attachment 221932: [PATCH] Proposed Fix - Passing Tests
https://bugs.webkit.org/attachment.cgi?id=221932&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221932&action=review


r=me

> Source/JavaScriptCore/inspector/InspectorAgentBase.h:38
> +    InspectedObjectBeingDestroyed,

Can we be a little more specific here? Based on your comment below, how about
"InspectedPageClosed"?

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:127
> +    disable(false);

Let's put "false" in a named local variable, to give context to its meaning.