[webkit-reviews] review granted: [Bug 127454] WKBrowsingContextController should not be an API wrapper around WebPageProxy : [Attachment 221923] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 22 18:21:08 PST 2014


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127454: WKBrowsingContextController should not be an API wrapper around
WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=127454

Attachment 221923: Patch
https://bugs.webkit.org/attachment.cgi?id=221923&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221923&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:42
> -- (void)_finishInitialization;
>  + (NSMutableSet *)customSchemes;
>  
> +- (instancetype)_initWithPageRef:(WKPageRef)pageRef;
> ++ (WKBrowsingContextController
*)_browsingContextControllerForPageRef:(WKPageRef)pageRef;

Class methods before instance methods, please.


More information about the webkit-reviews mailing list