[webkit-reviews] review requested: [Bug 127409] Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer : [Attachment 221927] [PATCH] Proposed Fix - Passing Tests

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 127409: Web Inspector: Remove recompileAllJSFunctions timer in
ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=127409

Attachment 221927: [PATCH] Proposed Fix - Passing Tests
https://bugs.webkit.org/attachment.cgi?id=221927&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Problem:
When the Web Inspector was implicitly closed via JavaScript (e.g.
window.close() or in LayoutTests as
window.internals.closeDummyInspectorFrontend()) we were disconnecting
InspectorDebuggerAgent and calling to recompileAllJSFunctions from within a
JavaScript stack.

Solution:
Give agents a reason enum when they are disconnecting. The reasons can be:
  - InspectedObjectIsBeingDestroyed - no need to recompile functions here, the
object is going to be deleted.
  - FrontendDisconnected - we should recompile functions so the page can be as
good as new

Other Stuff:
Now that we don't use a Timer for recompiling scripts, as soon as the backend
gets DebuggerAgent.enable, it starts recompiling and sending sourceParsed
events to the frontend. That changes the order expected by inspector-protocol
tests. Not in any significant way, but it makes the setBreakpointsActive calls
output seemingly random. Remove all these unnecessary calls and output of
"Breakpoints Enabled". Breakpoints are already enabled by default anyways.