[webkit-reviews] review denied: [Bug 125028] [Curl] There is no way to specify cache folder. : [Attachment 221782] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 125028: [Curl] There is no way to specify cache folder.
https://bugs.webkit.org/show_bug.cgi?id=125028

Attachment 221782: Patch
https://bugs.webkit.org/attachment.cgi?id=221782&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221782&action=review


Minor nit-pick about prefixing with ::.  Could you please fix that, and I'll r+
it?

> Tools/WinLauncher/WinLauncher.cpp:402
> +    PathRemoveExtensionW(executablePath);

We prefix C API calls with ::, so these should be ::GetModuleFileNameW and
::PathRemoveExtensionW.

> Tools/WinLauncher/WinLauncher.cpp:404
> +    directory = _bstr_t(appDataDirectory) + L"\\" +
PathFindFileNameW(executablePath);

This should be ::PathFindFileNameW, too.