[webkit-reviews] review granted: [Bug 127444] Add WKWebView class : [Attachment 221901] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127444: Add WKWebView class
https://bugs.webkit.org/show_bug.cgi?id=127444

Attachment 221901: Patch
https://bugs.webkit.org/attachment.cgi?id=221901&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221901&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:65
> +- (instancetype)initWithFrame:(CGRect)frame
configuration:(WKWebViewConfiguration *)configuration
NS_DESIGNATED_INITIALIZER;

I think you meant WK_DESIGNATED_INITIALIZER.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:37
> +- (instancetype)initWithFrame:(CGRect)frame
configuration:(WKWebViewConfiguration *)configuration

Please add a FIXME about overriding -initWithFrame: to do what the header says
it should do.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:42
> +    _configuration = adoptNS([configuration copy]);

Please add a FIXME here about filling in a configuration that has nil
properties with concrete default instances.