[webkit-reviews] review granted: [Bug 127401] IDB: Support "put" : [Attachment 221829] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 22 13:59:25 PST 2014


Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 127401: IDB: Support "put"
https://bugs.webkit.org/show_bug.cgi?id=127401

Attachment 221829: Patch v1
https://bugs.webkit.org/attachment.cgi?id=221829&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221829&action=review


Please fix non-Mac builds.

> Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE, INC. ``AS IS'' AND ANY

I'm not sure if these headers are correct. Did you get it from webkit.org?

This says "Apple Inc." in copyright line, but "APPLE, INC." with a comma
inside.

> Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:69
> +PassRefPtr<IDBKey> IDBKeyData::maybeCreateIDBKey() const

maybe?

> Source/WebKit2/DatabaseProcess/IndexedDB/IDBSerialization.cpp:57
> +RefPtr<WebCore::SharedBuffer> serializeIDBKey(const WebCore::IDBKey& key)

We should have "using namespace WebCore" in this file if we don't yet.

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:396
> +void UniqueIDBDatabase::putRecord(const IDBTransactionIdentifier&
identifier, int64_t objectStoreID, const WebCore::IDBKeyData& keyData, const
IPC::DataReference& value, int64_t putMode, const Vector<int64_t>& indexIDs,
const Vector<Vector<WebCore::IDBKeyData>>& indexKeys, std::function<void(const
IDBKeyData&, uint32_t, const String&)> callback)

Ditto.

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:409
> +    }, [this, callback]() {

Hopefully something protects "this" while the request is in progress.

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:528
> +    // FIXME: The LevelDB post performs "makeIndexWriters" here. Necessary?

"post" looks like a typo.


More information about the webkit-reviews mailing list