[webkit-reviews] review granted: [Bug 127443] Web Inspector: Don't include a hidden Timeline selection in the navigation path components : [Attachment 221895] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 127443: Web Inspector: Don't include a hidden Timeline selection in the
navigation path components
https://bugs.webkit.org/show_bug.cgi?id=127443

Attachment 221895: Patch
https://bugs.webkit.org/attachment.cgi?id=221895&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221895&action=review


r=me

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:47
> +	   if (!previousSibling)
>	       return null;

This early return can be removed, since the loop below will check if
previousSibling and do the right thing.

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:62
> +	   if (!nextSibling)
>	       return null;

Ditto