[webkit-reviews] review granted: [Bug 127350] [CSS Background Blending] -webkit-background-blend-mode fails for certain SVG files : [Attachment 221853] Patch V1

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 127350: [CSS Background Blending] -webkit-background-blend-mode fails for
certain SVG files
https://bugs.webkit.org/show_bug.cgi?id=127350

Attachment 221853: Patch V1
https://bugs.webkit.org/attachment.cgi?id=221853&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221853&action=review


snippets. Otherwise great.

> Source/WebCore/ChangeLog:10
> +	   [CSS Background Blending] Background blending works
> +	   incorrectly for certain SVG background layers: the
> +	   graphics context of the SVG inherits the blend mode set
> +	   on the background layer. Fix consists in drawing the SVG
> +	   in a transparency layer.
> +	   https://bugs.webkit.org/show_bug.cgi?id=127350
> +
> +	   Reviewed by NOBODY (OOPS!).

The style for changelegs are:

date  name  email

Bug title
bug reference

reviewed by

fix description.

tests

* changed files

> Source/WebCore/ChangeLog:15
> +	   (WebCore::SVGImage::draw): begin a transparency layer if a blend
mode is set.

s/begin/Begin/

> LayoutTests/css3/compositing/background-blend-mode-svg.html:12
> +	   -webkit-background-blend-mode: multiply, normal;

One value should be enough here, right?