[webkit-reviews] review granted: [Bug 127343] [CSS Regions] layerOwner in RenderNamedFlowFragment cannot return null : [Attachment 221741] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Mihai Maerean <mmaerean at adobe.com>'s
request for review:
Bug 127343: [CSS Regions] layerOwner in RenderNamedFlowFragment cannot return
null
https://bugs.webkit.org/show_bug.cgi?id=127343

Attachment 221741: patch
https://bugs.webkit.org/attachment.cgi?id=221741&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221741&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:256
>      for (auto iter = m_regionList.begin(), end = m_regionList.end(); iter !=
end; ++iter)
> -	   if (RenderLayerModelObject* layerOwner =
toRenderNamedFlowFragment(*iter)->layerOwner())
> -	       if (layerOwner->hasLayer() &&
layerOwner->layer()->hasCompositingDescendant())
> -		   return true;
> +	   if
(toRenderNamedFlowFragment(*iter)->layerOwner().layer()->hasCompositingDescenda
nt())
> +	       return true;

You should totally convert this loop to for-range style while you are here.

> Source/WebCore/rendering/RenderLayer.cpp:6940
> +    LayoutRect regionContentBox =
toRenderBox(&region->layerOwner())->contentBoxRect();

This can probably be:
LayoutRect regionContentBox =
toRenderBox(region->layerOwner()).contentBoxRect();