[webkit-reviews] review granted: [Bug 127403] Add a minimalistic SPI to control the layout size outside of WKView : [Attachment 221826] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 21 21:27:31 PST 2014


Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 127403: Add a minimalistic SPI to control the layout size outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=127403

Attachment 221826: Patch
https://bugs.webkit.org/attachment.cgi?id=221826&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221826&action=review


>>> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:45
>>> +- (void)overrideMinimumLayoutSize:(CGSize)forcedSize;
>> 
>> Might this work better as a property?  E.g.
>> 
>> @property (nonatomic) CGSize minimumLayoutSizeOverride;
> 
> The "looks good to me either way" was meant to be after that comment…

I agree, a property might be better. r=me.


More information about the webkit-reviews mailing list