[webkit-reviews] review granted: [Bug 127336] Add protocolIsInHTTPFamily for strings and use it where appropriate : [Attachment 221726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 21 18:32:41 PST 2014


Darin Adler <darin at apple.com> has granted jochen at chromium.org's request for
review:
Bug 127336: Add protocolIsInHTTPFamily for strings and use it where appropriate
https://bugs.webkit.org/show_bug.cgi?id=127336

Attachment 221726: Patch
https://bugs.webkit.org/attachment.cgi?id=221726&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221726&action=review


>> Source/WebCore/platform/URL.cpp:1780
>> +	return protocolIs(url, "http") || protocolIs(url, "https");
> 
> This function seems like it could be made faster - we check for "http" prefix
twice here.

I agree that we could make a tighter version.


More information about the webkit-reviews mailing list