[webkit-reviews] review denied: [Bug 127275] Move HistoryItem to std::unique_ptr : [Attachment 221720] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 127275: Move HistoryItem to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127275

Attachment 221720: Patch
https://bugs.webkit.org/attachment.cgi?id=221720&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221720&action=review


Looks good, but is missing necessary changes in Mac and Windows code. r- for
these build failures.

> Source/WebCore/history/HistoryItem.cpp:225
> +    m_redirectURLs = nullptr;

You need to make a similar change in history/mac/HistoryItemMac.mm.

> Source/WebCore/history/HistoryItem.h:183
> +    void setRedirectURLs(std::unique_ptr<Vector<String>>);

Some Windows code (WebKit/win/WebHistoryItem.cpp) still thinks this argument is
a PassOwnPtr.