[webkit-reviews] review denied: [Bug 125779] [curl] Add storage limit to cache manager : [Attachment 219646] Proposed patch 2

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Mátyás Mustoha
<mmatyas at inf.u-szeged.hu>'s request for review:
Bug 125779: [curl] Add storage limit to cache manager
https://bugs.webkit.org/show_bug.cgi?id=125779

Attachment 219646: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=219646&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219646&action=review


This change seems fine, but I think it could be a little better if we used
C++11 auto types. I'm also not sure the 'long long' declaration is a good idea
here.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:345
> +	   long long contentFileSize;

It might be better to use a specific size here, such as uint64_t/int64_t.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:169
> +    ListHashSet<String>::iterator end = m_LRUEntryList.end();

Make these 'auto'. In fact, they should probably be const.