[webkit-reviews] review denied: [Bug 127200] [CSS Shapes] Preserve box-shape order when serializing shape values : [Attachment 221688] Factoring code common to shapes and clipping

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Bear Travis <betravis at adobe.com>'s
request for review:
Bug 127200: [CSS Shapes] Preserve box-shape order when serializing shape values
https://bugs.webkit.org/show_bug.cgi?id=127200

Attachment 221688: Factoring code common to shapes and clipping
https://bugs.webkit.org/attachment.cgi?id=221688&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221688&action=review


Patch looks great! Just some smaller snippets.

> Source/WebCore/css/CSSParser.cpp:5862
> +PassRefPtr<CSSValue> CSSParser::parseBasicShapeAndOrBox(bool
allowBoundingBox)

Could you make that a static function or inline function please? Could you
replace the boolean with a CSSPropertyID and check the id instead? That makes
understanding the code easier.

> Source/WebCore/css/CSSParser.h:182
> +    PassRefPtr<CSSValue> parseBasicShapeAndOrBox(bool allowBoundingBox);

See comment above