[webkit-reviews] review granted: [Bug 127263] [EFL][WK2] Use nanoseconds in TimerWorkItem class consistently : [Attachment 221619] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 21 00:46:00 PST 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 127263: [EFL][WK2] Use nanoseconds in TimerWorkItem class consistently
https://bugs.webkit.org/show_bug.cgi?id=127263
Attachment 221619: Patch
https://bugs.webkit.org/attachment.cgi?id=221619&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221619&action=review
>>> Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:245
>>> + double timeOutSeconds =
(m_timerWorkItems[0]->expirationTimeNanoSeconds() -
monotonicallyIncreasingTime() * nanoSecondsPerSecond) / nanoSecondsPerSecond;
>>
>> It looks "* nanoSecondsPerSecond) / nanoSecondsPerSecond;" is useless.
>
> monotonicallyIncreasingTime() is seconds but
'm_timerWorkItems[0]->expirationTimeNanoSeconds()' is nanoseconds.
I'm sorry. I mistook this code. Yes, looks correct.
More information about the webkit-reviews
mailing list