[webkit-reviews] review granted: [Bug 127314] Web Inspector: Add the recording button back to the Timelines sidebar : [Attachment 221699] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 127314: Web Inspector: Add the recording button back to the Timelines
sidebar
https://bugs.webkit.org/show_bug.cgi?id=127314

Attachment 221699: Patch
https://bugs.webkit.org/attachment.cgi?id=221699&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221699&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:311
> +	       // We have a current time alredy, so we likely need to jump into
the future to a better current time.

Typo: alredy => already

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:378
>      _recordingReset: function(event)
>      {
> -	   this._startTimeNeedsReset = true;
>	   this._currentTime = NaN;
>  
> +	   if (!this._updating) {
> +	       // Force the time ruler and views to reset to 0.
> +	       this._startTimeNeedsReset = true;
> +	       this._updateTimes(0, 0, 0);
> +	   }
> +
> +	   this._lastUpdateTimestamp = NaN;
> +	   this._startTimeNeedsReset = true;

Should this also delete this._waitingToResetCurrentTime if it was waiting?
Seeing as we just deleted currentTime.