[webkit-reviews] review granted: [Bug 127273] [GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function : [Attachment 221634] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 127273: [GTK][WK2] Move the rest of GTK's WorkQueue implementation to
std::function
https://bugs.webkit.org/show_bug.cgi?id=127273

Attachment 221634: Patch
https://bugs.webkit.org/attachment.cgi?id=221634&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221634&action=review


> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:73
> +	   : EventSource(std::forward<std::function<void ()>>(function),
workQueue)

This should just use std::move.

> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:170
> -    SocketEventSource* eventSource = new SocketEventSource(function, this,
cancellable.get(), closeFunction);
> +    SocketEventSource* eventSource = new
SocketEventSource(std::forward<std::function<void ()>>(function), this,
> +	   cancellable.get(), std::forward<std::function<void
()>>(closeFunction));

This should use std::move instead of std::forward.