[webkit-reviews] review granted: [Bug 126869] Do refactor in collectGradientAttributes() and renderStyleForLengthResolve() : [Attachment 221607] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 20 06:41:19 PST 2014
Dirk Schulze <krit at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 126869: Do refactor in collectGradientAttributes() and
renderStyleForLengthResolve()
https://bugs.webkit.org/show_bug.cgi?id=126869
Attachment 221607: Patch
https://bugs.webkit.org/attachment.cgi?id=221607&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221607&action=review
I do not see a huge improvement of the code in comparison to the previous code.
Adapting to the new style rules is still a fine. r=me
> Source/WebCore/ChangeLog:9
> + one of poor implementations. This cl fix it by extracting a logic
into a new method.
cl may be replaced.
More information about the webkit-reviews
mailing list