[webkit-reviews] review granted: [Bug 127265] EWS should provide better information to Dashboard via JSON : [Attachment 221617] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 19 23:17:42 PST 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 127265: EWS should provide better information to Dashboard via JSON
https://bugs.webkit.org/show_bug.cgi?id=127265
Attachment 221617: proposed patch
https://bugs.webkit.org/attachment.cgi?id=221617&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221617&action=review
> Tools/QueueStatusServer/app.yaml:2
> -version: 162287 # Bugzilla bug ID of last major change
> +version: ap # Bugzilla bug ID of last major change
This doesn't look right.
> Tools/QueueStatusServer/handlers/queuestatusjson.py:59
> +
Nit: Whitespaces.
> Tools/QueueStatusServer/handlers/queuestatusjson.py:74
> def _bots(self, queue):
> + # Collect all bots that ever served this queue.
Why don't we rename the method instead of adding a comment like this?
More information about the webkit-reviews
mailing list