[webkit-reviews] review granted: [Bug 127259] [EFL][WK2] build fix after r162276 : [Attachment 221602] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 127259: [EFL][WK2] build fix after r162276
https://bugs.webkit.org/show_bug.cgi?id=127259

Attachment 221602: Patch
https://bugs.webkit.org/attachment.cgi?id=221602&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221602&action=review


> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:37
> +    static std::unique_ptr<WorkItem> create(PassRefPtr<WorkQueue> workQueue,
std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:39
>	   return std::unique_ptr<WorkItem>(new WorkItem(workQueue, function));


Can to std::move(function) here

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:44
> +    WorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()>
function)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:46
>	   , m_function(function)

Can do std::move(function) here.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57
> +    static std::unique_ptr<TimerWorkItem> create(PassRefPtr<WorkQueue>
workQueue, std::function<void()> function, double delaySeconds)

Space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:60
>	   return std::unique_ptr<TimerWorkItem>(new TimerWorkItem(workQueue,
function, currentTime() + delaySeconds));

std::move(function).

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66
> +    TimerWorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()>
function, double expirationTimeSeconds)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:67
>	   : WorkItem(workQueue, function)

std::move(function).

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55
> +void WorkQueue::dispatch(std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:60
>      m_dispatchQueue->dispatch(WorkItem::create(this, function));

std::move(function).

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63
> +void WorkQueue::dispatchAfter(std::chrono::nanoseconds duration,
std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:68
> +    m_dispatchQueue->dispatch(TimerWorkItem::create(this, function,
duration.count() / 1000000000ULL));

std::move(function).