[webkit-reviews] review denied: [Bug 126869] Do refactor in collectGradientAttributes() and renderStyleForLengthResolve() : [Attachment 221585] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 126869: Do refactor in collectGradientAttributes() and
renderStyleForLengthResolve()
https://bugs.webkit.org/show_bug.cgi?id=126869

Attachment 221585: Patch
https://bugs.webkit.org/attachment.cgi?id=221585&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221585&action=review


> Source/WebCore/svg/SVGLengthContext.cpp:207
>	   return 0;

Change this 0 to a nullptr while you are here.

> Source/WebCore/svg/SVGLinearGradientElement.cpp:126
> +static void setGradientAttributes(SVGGradientElement* element,
LinearGradientAttributes& attributes, bool isLinear = true)

If SVGGradientElement* is never null, please convert it to a
SVGGradientElement^

> Source/WebCore/svg/SVGRadialGradientElement.cpp:138
> +static void setGradientAttributes(SVGGradientElement* element,
RadialGradientAttributes& attributes, bool isRadial = true)

SVGGradientElement&