[webkit-reviews] review granted: [Bug 127211] Use unsigned type for the size of CSSParserValueList : [Attachment 221529] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 18 15:40:38 PST 2014


Andreas Kling <akling at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 127211: Use unsigned type for the size of CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=127211

Attachment 221529: Patch
https://bugs.webkit.org/attachment.cgi?id=221529&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221529&action=review


> Source/WebCore/css/CSSParser.cpp:1798
> -    int num = inShorthand() ? 1 : m_valueList->size();
> +    unsigned num = inShorthand() ? 1 : m_valueList->size();

There's identical code on line 3499. Please make the same change there.


More information about the webkit-reviews mailing list