[webkit-reviews] review granted: [Bug 127236] Modernize HTML parser code : [Attachment 221571] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127236: Modernize HTML parser code
https://bugs.webkit.org/show_bug.cgi?id=127236

Attachment 221571: Patch
https://bugs.webkit.org/attachment.cgi?id=221571&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221571&action=review


r=me

> Source/WebCore/html/parser/CSSPreloadScanner.cpp:214
> -	       OwnPtr<PreloadRequest> request = PreloadRequest::create("css",
url, baseElementURL, CachedResource::CSSStyleSheet);
> +
> +	       auto request = std::make_unique<PreloadRequest>("css", url,
baseElementURL, CachedResource::CSSStyleSheet, String());
>	       // FIXME: Should this be including the charset in the preload
request?
> -	       m_requests->append(request.release());
> +	       m_requests->append(std::move(request));

I'd lose the temporary.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:388
> -	       m_insertionPreloadScanner = adoptPtr(new
HTMLPreloadScanner(m_options, document()->url(),
document()->deviceScaleFactor()));
> +	       m_insertionPreloadScanner = std::make_unique<
HTMLPreloadScanner>(m_options, document()->url(),
document()->deviceScaleFactor());

Extra space after < here.

> Source/WebCore/html/parser/HTMLResourcePreloader.cpp:66
>  void HTMLResourcePreloader::takeAndPreload(PreloadRequestStream& r)
>  {
> -    PreloadRequestStream requests;
> -    requests.swap(r);
> +    PreloadRequestStream requests = std::move(r);

This is a bit awkward.