[webkit-reviews] review granted: [Bug 127217] Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method : [Attachment 221544] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 127217: Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a
method
https://bugs.webkit.org/show_bug.cgi?id=127217

Attachment 221544: Patch
https://bugs.webkit.org/attachment.cgi?id=221544&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221544&action=review


Are there any other call sites that use the bad syntax?

> Tools/ChangeLog:8
> +	   Call the tempdir() function using the proper syntax.

Although you document the commit that made the old syntax invalid, you may want
to consider adding a remark that explains that we were using an undocumented
calling convention and that this convention has been explicitly made invalid
following
<https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02
b9410e0e4c3d74f565>. It would be great if we also documented the version of
Perl this change affected.