[webkit-reviews] review granted: [Bug 127221] Remove DocumentParser::pinToMainThread() and related code : [Attachment 221552] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 127221: Remove DocumentParser::pinToMainThread() and related code
https://bugs.webkit.org/show_bug.cgi?id=127221

Attachment 221552: Patch
https://bugs.webkit.org/attachment.cgi?id=221552&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221552&action=review


r=me

> Source/WebCore/dom/DocumentParser.h:-53
> -    virtual void pinToMainThread() { }

Stupid that we always ate this virtual in unthreaded builds.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:74
> +    , m_tokenizer(HTMLTokenizer::create(m_options))

Maybe this doesn't need to be heap allocated anymore.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:88
> -    ASSERT(shouldUseThreading() || (m_token && m_tokenizer));
> +    ASSERT(m_token);
> +    ASSERT(m_tokenizer);

I guess we shouldn't even really need these assertions in the end.