[webkit-reviews] review requested: [Bug 127071] CStack Branch: X86-32 Fix LLInt : [Attachment 221527] Patch with updates after conversation with Mark

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 20:51:30 PST 2014


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 127071: CStack Branch: X86-32 Fix LLInt
https://bugs.webkit.org/show_bug.cgi?id=127071

Attachment 221527: Patch with updates after conversation with Mark
https://bugs.webkit.org/attachment.cgi?id=221527&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Fixed the rounding math to use JSStack::CallFrameHeaderSize for argument count
rounding and JSStack::CallerFrameAndPCSize for local register count rounding. 
What Mark was calling framePointerAlignmentOvershoot is really
roundUpToMultipleOf(stackAlignmentRegisters(), JSStack::CallerFrameAndPCSize). 
I used that directly in the local register rounding computation.


More information about the webkit-reviews mailing list