[webkit-reviews] review granted: [Bug 127022] Web Inspector: Implement the discrete Network timeline view : [Attachment 221216] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 127022: Web Inspector: Implement the discrete Network timeline view
https://bugs.webkit.org/show_bug.cgi?id=127022

Attachment 221216: Patch
https://bugs.webkit.org/attachment.cgi?id=221216&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221216&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:294
> +	       if (isNaN(value1))
> +		   return sortDirection * -1;
> +	       if (isNaN(value2))
> +		   return sortDirection * 1;

How about just return -sortDirection and return sortDirection?