[webkit-reviews] review granted: [Bug 108184] ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase : [Attachment 221467] Corrected patch

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has granted Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 108184: ASSERT(time.isFinite()) in
SVGSMILElement::createInstanceTimesFromSyncbase
https://bugs.webkit.org/show_bug.cgi?id=108184

Attachment 221467: Corrected patch
https://bugs.webkit.org/attachment.cgi?id=221467&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221467&action=review


This looks good to me. One minor issue with the test.

> LayoutTests/svg/animations/smil-syncbase-self-dependency.svg:14
> +	       document.getElementById("label").textContent = "SMILElement
animation time self-dependency is" +

Why not end the test here?

You can do:
document.write("SMILElement animation ... etc");
if (testRunner)
    testRunner.notifyDone();