[webkit-reviews] review granted: [Bug 127128] Inspector scripts are not compatible with Python v3 : [Attachment 221453] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 17 13:09:21 PST 2014
Benjamin Poulain <benjamin at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 127128: Inspector scripts are not compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=127128
Attachment 221453: Patch
https://bugs.webkit.org/attachment.cgi?id=221453&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221453&action=review
cool!
> Source/JavaScriptCore/inspector/scripts/jsmin.py:36
> +try:
> + from StringIO import StringIO
> +except ImportError:
> + from io import StringIO
Maybe add a Python3 comment here so that we know to remove it in the future?
More information about the webkit-reviews
mailing list