[webkit-reviews] review granted: [Bug 127145] Web Inspector: Improve TimelineOverview by not putting TimelineRuler in a scroll area : [Attachment 221417] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 127145: Web Inspector: Improve TimelineOverview by not putting
TimelineRuler in a scroll area
https://bugs.webkit.org/show_bug.cgi?id=127145

Attachment 221417: Patch
https://bugs.webkit.org/attachment.cgi?id=221417&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221417&action=review


r=me

> Source/WebInspectorUI/UserInterface/TimelineOverview.js:178
> +	   this.scrollStartTime = marker.time - (this.visibleDuration / 2);

Maybe in the future we can be a bit smarter here and reveal the entire marker
if it fits in the overview with some padding. Currently this attempts to center
the marker? That sounds like a good default.

> Source/WebInspectorUI/UserInterface/TimelineOverview.js:266
> +	   if (Math.abs(event.deltaX) >= Math.abs(event.deltaY) * 0.5) {
> +	       // Clone the event to dispatch it on the scroll container. Mark
it as cloned so we don't get into a loop.
> +	       var newWheelEvent = new event.constructor(event.type, event);
> +	       newWheelEvent.__cloned = true;

Clever!