[webkit-reviews] review denied: [Bug 127171] Script make_names.pl should generate lazily created arrays for attributes and tags. : [Attachment 221455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 17 09:10:38 PST 2014


Darin Adler <darin at apple.com> has denied Vivek Galatage <vivekg at webkit.org>'s
request for review:
Bug 127171: Script make_names.pl should generate lazily created arrays for
attributes and tags.
https://bugs.webkit.org/show_bug.cgi?id=127171

Attachment 221455: Patch
https://bugs.webkit.org/attachment.cgi?id=221455&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221455&action=review


> Source/WebCore/ChangeLog:17
> +	   As the pointer data itself is global, the array need not be declared
as static. 
> +	   We could create it lazily.
> +
> +	   Also even though these functions, get{{namespace}}Tags/Attrs(), may
not be called upon,
> +	   the binary would still be loaded with allocation of that much amount
of static data. 

Doesn’t seem like a good tradeoff to me. In most systems, there is no
significant cost to having static data that is never accessed, due to virtual
memory and the OS. The code to build this structure seems like it will be
significantly bigger than the data object.

Was there some specific case where this savings proved worthwhile? Could you
give some numbers for the improvement?

> Source/WebCore/dom/make_names.pl:704
> +    printHeaderHead($F, "DOM", $parameters{namespace}, "#include
\"QualifiedName.h\"\n#include <wtf/PassOwnPtr.h>\n");

This is wrong. Code doesn’t use PassOwnPtr.


More information about the webkit-reviews mailing list