[webkit-reviews] review granted: [Bug 127161] Get rid of OpaqueJSString::deprecatedCharacters() : [Attachment 221440] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 127161: Get rid of OpaqueJSString::deprecatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=127161

Attachment 221440: Patch
https://bugs.webkit.org/attachment.cgi?id=221440&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221440&action=review


> Source/JavaScriptCore/API/OpaqueJSString.cpp:45
> +    if (UChar* characters = m_characters)
> +	   fastFree(static_cast<void*>(characters));

You should add a comment about why you are putting this in a local.

> Source/JavaScriptCore/API/OpaqueJSString.cpp:78
> +    UChar* characters = m_characters;
> +    if (characters)
> +	   return characters;

Same here.