[webkit-reviews] review granted: [Bug 127123] IDB: delete object store support : [Attachment 221393] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 127123: IDB: delete object store support
https://bugs.webkit.org/show_bug.cgi?id=127123

Attachment 221393: Patch v1
https://bugs.webkit.org/attachment.cgi?id=221393&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221393&action=review


> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:365
> +void UniqueIDBDatabase::deleteObjectStore(const IDBTransactionIdentifier&
identifier, int64_t objectStoreID, std::function<void(bool)> successCallback)

I'm not quite sure how we can have a success callback, but no failure callback.
Isn't it just "callback" then?

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:78
>      void changeDatabaseVersion(const IDBTransactionIdentifier&, uint64_t
newVersion, std::function<void(bool)> successCallback);
>      void createObjectStore(const IDBTransactionIdentifier&, const
WebCore::IDBObjectStoreMetadata&, std::function<void(bool)> successCallback);
> +    void deleteObjectStore(const IDBTransactionIdentifier&, int64_t
objectStoreID, std::function<void(bool)> successCallback);

I'm similarly unsure about the existing ones.

>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:394
> +	   LOG_ERROR("Attempt to change database version with an establish,
in-progress transaction");

Should that be "established"?

>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:412
> +	   // FIXME: Execute SQL here to drop all records and indexes related
to this object store.

Is there a bug tracking this?