[webkit-reviews] review canceled: [Bug 127014] AnimationController: replace animation timer with compositor-driven mechanism : [Attachment 221409] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 16 13:55:51 PST 2014


Ralph T <ralpht+bugs at gmail.com> has canceled Ralph T <ralpht+bugs at gmail.com>'s
request for review:
Bug 127014: AnimationController: replace animation timer with compositor-driven
mechanism
https://bugs.webkit.org/show_bug.cgi?id=127014

Attachment 221409: Patch
https://bugs.webkit.org/attachment.cgi?id=221409&action=review

------- Additional Comments from Ralph T <ralpht+bugs at gmail.com>
Again, just for discussion/feedback. This should correct the LayoutTest
regression the previous version had.

I'm more sure that the chunkiness on mac is from using the CA timer and the
DisplayMonitor mechanism. I imagine that as mac starts using the remote layer
tree that you'll want to stop using the DisplayMonitor in the WebProcess
completely.

I might try a change on mac to service rAFs from the LayerFlushScheduler and
see if mac is smoother then, though I'm not very familiar with the mac port, so
perhaps I'm completely misunderstanding what I'm seeing.


More information about the webkit-reviews mailing list