[webkit-reviews] review granted: [Bug 127082] Draw all underline segments in a particular run in the same call : [Attachment 221399] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 127082: Draw all underline segments in a particular run in the same call
https://bugs.webkit.org/show_bug.cgi?id=127082

Attachment 221399: Patch
https://bugs.webkit.org/attachment.cgi?id=221399&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221399&action=review


> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1496
> +    Vector<CGRect> dashBounds;

Inline capacity, and set capacity up front?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1507
> +    if (fillColor() != strokeColor())

You could avoid doing this comparison twice.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1518
> +    CGContextRef context = platformContext();
> +    CGContextSaveGState(context);

Odd that this is so different. Why save/restore here and not above?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1525
> +    Vector<CGRect> dashBounds;

Ditto.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1530
> +    if (m_state.shouldUseContextColors)

Is m_state.shouldUseContextColors iOS-specific? What does it mean?