[webkit-reviews] review granted: [Bug 126935] Add support for managing WebGL load policy : [Attachment 221395] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 126935: Add support for managing WebGL load policy
https://bugs.webkit.org/show_bug.cgi?id=126935

Attachment 221395: Patch
https://bugs.webkit.org/attachment.cgi?id=221395&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=221395&action=review


> Source/WebKit2/UIProcess/WebLoaderClient.cpp:337
> +WebCore::WebGLLoadPolicy WebLoaderClient::webGLLoadPolicy(WebPageProxy*
page, const String& site) const

s/site/url/, I think?

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2683
> +void WebPageProxy::webGLPolicyForSite(const String& site, uint32_t&
loadPolicy)

s/Site/URL/, I think?

> Source/WebKit2/UIProcess/WebPageProxy.h:930
> +    void webGLPolicyForSite(const String& site, uint32_t& loadPolicy);

ditto

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:37
> +    WebGLPolicyForSite(String host) -> (uint32_t loadPolicy)

ditto

> Source/WebKit2/UIProcess/API/C/WKAPICast.h:488
> +    return WebCore::WebGLAsk;

your default in other places seems to be Allow; why Ask here?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1342
> +WebCore::WebGLLoadPolicy WebFrameLoaderClient::webGLPolicyForSite(const
String& site) const

ditto

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:190
> +    virtual WebCore::WebGLLoadPolicy webGLPolicyForSite(const String&) const
OVERRIDE;

ditto

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:603
> +WebCore::WebGLLoadPolicy WebPage::webGLPolicyForSite(WebFrame* frame, const
String& url)

ditto (and here hilariously the argument is url already)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:293
> +    WebCore::WebGLLoadPolicy webGLPolicyForSite(WebFrame*, const String&);

ditto