[webkit-reviews] review granted: [Bug 127081] AX: WebKit is not firing AXMenuItemSelectedNotification : [Attachment 221328] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 127081: AX: WebKit is not firing AXMenuItemSelectedNotification
https://bugs.webkit.org/show_bug.cgi?id=127081

Attachment 221328: patch
https://bugs.webkit.org/attachment.cgi?id=221328&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221328&action=review


Lgtm

> Source/WebCore/accessibility/AXObjectCache.cpp:742
> +    if (nodeHasRole(node, "menuitem") || nodeHasRole(node, "menuitemradio")
|| nodeHasRole(node, "menuitemcheckbox")) {

Nit. I think an early return for this condition would be cleaner. I would also
add a null check for node to the OR.