[webkit-reviews] review granted: [Bug 126914] AX: Do not return an accessible name for an object just because it has tabindex=0 : [Attachment 221059] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 126914: AX: Do not return an accessible name for an object just because it
has tabindex=0
https://bugs.webkit.org/show_bug.cgi?id=126914

Attachment 221059: patch
https://bugs.webkit.org/attachment.cgi?id=221059&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=221059&action=review


The patch looks good to me, although I don't understand why you are getting
that undefined expectation for one test. Also, I think we might potentially
have to adapt the ATK port after this change, but I'm happy to give it a try
now and adapt later so VO is not blocked on theories :)

Setting the r+ anyway, but please take a look to the issue with the FAIL
expectation before landing

> LayoutTests/accessibility/focusable-div-expected.txt:17
> -PASS lastChar(axDiv.title) is "B"
> +FAIL lastChar(axDiv.title) should be undefined (of type undefined). Was  
(of type string).

This FAIL expectation looks wrong. Not sure why this is happening, though (why
is "" undefined?)

> LayoutTests/accessibility/focusable-div-expected.txt:19
> +FAIL lastChar(axDiv2.title) should be undefined (of type undefined). Was  
(of type string).

Same here